Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow specifying credentials for source registry on import image #4049

Merged
merged 1 commit into from
Oct 8, 2018
Merged

allow specifying credentials for source registry on import image #4049

merged 1 commit into from
Oct 8, 2018

Conversation

nathana1
Copy link
Contributor

@nathana1 nathana1 commented Oct 1, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from marstr October 1, 2018 21:59
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3467

@AutorestCI AutorestCI mentioned this pull request Oct 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1574

@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3780

@AutorestCI AutorestCI mentioned this pull request Oct 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2880

This was referenced Oct 1, 2018
Closed
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 1, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

@djyou djyou mentioned this pull request Oct 4, 2018
Merged
@marstr
Copy link
Member

marstr commented Oct 8, 2018

Ready for me to merge, @nathana1?

@nathana1
Copy link
Contributor Author

nathana1 commented Oct 8, 2018

@djyou, @xiadu94 where are we on this?

@djyou
Copy link
Member

djyou commented Oct 8, 2018

@nathana1 Looks good. We'll release SDK once this is merged.

@marstr marstr merged commit 3396533 into Azure:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr approved these changes

@djyou djyou djyou approved these changes

Assignees

@marstr marstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nathana1 @AutorestCI @azuresdkci @marstr @djyou